Skip to content

Add lpc845-pac & hal #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2020
Merged

Add lpc845-pac & hal #235

merged 2 commits into from
Jan 10, 2020

Conversation

david-sawatzke
Copy link
Contributor

Lpc845 support was added to lpc82x-hal, so it was renamed lpc8xx-hal.

Also fixes a broken link

@rust-highfive
Copy link

r? @rahul-thakoor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Jan 3, 2020
jamesmunns
jamesmunns approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors r+

bors bot added a commit that referenced this pull request Jan 10, 2020
@bors @david-sawatzke
Merge #235
ecab615 
235: Add lpc845-pac & hal r=jamesmunns a=david-sawatzke

Lpc845 support was added to lpc82x-hal, so it was renamed lpc8xx-hal.

Also fixes a broken link

Co-authored-by: David Sawatzke <david-sawatzke@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jan 10, 2020

Build succeeded

@bors bors bot merged commit 40d23c2 into rust-embedded:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmunns jamesmunns jamesmunns approved these changes

@berkus berkus Awaiting requested review from berkus berkus is a code owner

@rahul-thakoor rahul-thakoor Awaiting requested review from rahul-thakoor rahul-thakoor is a code owner

@RandomInsano RandomInsano Awaiting requested review from RandomInsano RandomInsano is a code owner

Assignees

@rahul-thakoor rahul-thakoor

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@david-sawatzke @rust-highfive @jamesmunns @rahul-thakoor