Add the irq crate
#245
Merged
Add the irq crate
#245
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-schievink
requested review from
berkus,
rahul-thakoor,
RandomInsano and
a team
as code owners
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
|
bors does not check reviews for commands, only normal comments |
|
I'm sure bors does or used to check review comments for commands, it's how I've almost always r+'d PRs. Has it changed recently? |
|
bors r=andre-richter |
|
Yup done it this way since a long time. Strange... bors r+ |
|
Already running a review |
|
Huh, weird |
Build succeeded |
|
If anyone is investigating, I also wonder if Github could have changed the way bors “sees” comments that originate from review comments. Ill do separate review and bors steps from now on though. |
|
Looks like it's already filed: bors-ng/bors-ng#855 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.