Skip to content

Swap to GHA #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2021
Merged

Swap to GHA #328

merged 1 commit into from
Jun 17, 2021

Conversation

adamgreig
Copy link
Member

The travis CI wasn't even doing anything, but I guess at least this means we can use bors.

@rust-highfive
Copy link

r? @RandomInsano

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Jun 17, 2021
eldruin
eldruin approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!
bors r+

@eldruin
Copy link
Member

eldruin commented Jun 17, 2021

I guess this needs to be forcibly merged

@adamgreig
Copy link
Member Author

I've just removed travis_ci as a required CI status for merges, so only bors is required now, which I would have thought should pick up the new bors.toml to allow after dummy passes, let's see what bors says?

eldruin
eldruin approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially it was still waiting for travis but now it seems gone. Let's try again.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 17, 2021

Build succeeded:

@bors bors bot merged commit aaad925 into master Jun 17, 2021
@bors bors bot deleted the gha branch June 17, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

@berkus berkus Awaiting requested review from berkus berkus is a code owner

@rahul-thakoor rahul-thakoor Awaiting requested review from rahul-thakoor rahul-thakoor is a code owner

@RandomInsano RandomInsano Awaiting requested review from RandomInsano RandomInsano is a code owner

Assignees

@RandomInsano RandomInsano

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamgreig @rust-highfive @eldruin @RandomInsano