ch05 ch06 rewrite for micro:bit v2 #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ported all the code to the microbit BSP - Tested all the code commands etc. on v1.5 and v2 - ch06 doesn't need to be touched I think - currently relying on the git version of microbit since it introduces quite a few nice new APIs we want to use, microbit is (hopefully) going to make a release before this rewrite actually gets published - the solution to the ch05 challenge is arguably the most stupid way you could come up with to generate the matrix, at the same time this makes it simple enough to be understood by everyone though, which is certainly more important in this case
hargoniX
added
S-waiting-on-review
|
Member
Author
|
Hurray the CI is back \o/ |
eldruin
reviewed
Jul 23, 2021
Member
eldruin
left a comment
eldruin
left a comment
There was a problem hiding this comment.
Great stuff! I just added a few nit-picks
Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
bors bot
added a commit
that referenced
this pull request
Jul 23, 2021
381: ch05 ch06 rewrite for micro:bit v2 r=eldruin a=hargoniX - Ported all the code to the microbit BSP - Tested all the code commands etc. on v1.5 and v2 - ch06 doesn't need to be touched I think - currently relying on the git version of microbit since it introduces quite a few nice new APIs we want to use, microbit is (hopefully) going to make a release before this rewrite actually gets published - the solution to the ch05 challenge is arguably the most stupid way you could come up with to generate the matrix, at the same time this makes it simple enough to be understood by everyone though, which is certainly more important in this case Co-authored-by: Henrik Böving <hargonix@gmail.com>
Member
|
@hargoniX The |
Contributor
|
Timed out. |
eldruin
approved these changes
Jul 23, 2021
Member
eldruin
left a comment
eldruin
left a comment
There was a problem hiding this comment.
Thanks! let's try again.
bors r+
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduces quite a few nice new APIs we want to use,
microbit is (hopefully) going to make a release before
this rewrite actually gets published
way you could come up with to generate the matrix, at the
same time this makes it simple enough to be understood by everyone
though, which is certainly more important in this case