Skip to content

Conversation

@mark-i-m
Copy link
Contributor

Copy link
Contributor

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I forget how we're differentiating edition differences in the text. If someone else (Either @Havvy or @alercah ) could weigh in too, that'd be great.

@Centril
Copy link
Contributor

Centril commented Sep 18, 2018

@steveklabnik I'd like the reference to be more specification-like at some point including using BNF formalisms to define things like these; but for now, this seems good enough. :)

Copy link
Contributor

@Havvy Havvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes are for non-normative information. Please change it to "Edition Differences" or something similar. And bold it. And then, if you're up to it, add it to conventions.md. If not, I can add it in another PR.

@Havvy
Copy link
Contributor

Havvy commented Sep 20, 2018

I sent a PR against your branch. mark-i-m#1

@mark-i-m
Copy link
Contributor Author

Thanks @Havvy! Sorry I'm a bit sluggish. I'm in a bit of time crunch.

@Havvy
Copy link
Contributor

Havvy commented Sep 21, 2018

No need to apologize. You're not moving slower than anybody else on this repo. I just felt like making the changes, so I did..

@mark-i-m
Copy link
Contributor Author

@Havvy Perhaps this can be merged now?

@Havvy
Copy link
Contributor

Havvy commented Sep 22, 2018

I generally don't like merging things where I've sent commits.

@matthewjasper
Copy link
Contributor

Thank you both!

@matthewjasper matthewjasper merged commit a632079 into rust-lang:master Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants