Skip to content

Conversation

Muscraft
Copy link
Member

Having Title as an Element did not make sense, as Title is only meant to be used with Group::with_title, and Message should be used if you want similar output. Given that within our own tests, we were using Title when we should've been using Message, having both would have no doubt led to confusion for users over what to use.

Note: this adds a bit of duplication for how we handle continuations; the next few PRs should hopefully address some of it.

@epage
Copy link
Contributor

epage commented Jul 31, 2025

How come you didn't do the public/private enums?

@Muscraft
Copy link
Member Author

Having it be separate keeps the internal implementation in sync with the API, making it easier to reason about. I also found it nice to have everything for Title self-contained, as you don't have to think about it in relation to the other Elements.

@epage epage merged commit b6ccd6f into rust-lang:master Jul 31, 2025
15 checks passed
@Muscraft Muscraft deleted the no-title-element branch July 31, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants