fix: Make SIMD newline count match non-SIMD #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muscraft
force-pushed
the
fix-simd-newline-count
branch
from
60dc57f to
b43f04f
Compare
epage
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While migrating
cargotoannotate-snippets@0.12.0, I enabled thesimdfeature, and found that it wasn't correctly aligning things when the max line number was 10. After some digging, I figured out that the cause wassimd'snewline_countbeing off by 1. This PR fixes that issue and adds tests that will hopefully catch any regressions.To test this PR, run the following command on each commit: