Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyword generics initiative announcement post to the internals blog #1011

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

yoshuawuyts
Copy link
Member

This adds the announcement of the keyword generics initiative to the rust internals blog. I've set the release date for Monday the 25th of July, and marked the blog post as release: false in case it gets merged before then.

Thanks!

cc/ @rust-lang/initiative-keyword-generics

@Mark-Simulacrum
Copy link
Member

The release keyword is a marker for Rust releases, used to produce https://blog.rust-lang.org/releases.json (I believe currently feeding the version number on https://www.rust-lang.org/, but I'm not sure).

So it won't help with accidental merging :)

@Mark-Simulacrum
Copy link
Member

It also looks like this post is in posts/, not posts/inside-rust/, which is presumably an oversight? It sounds like you intended to put this on Inside Rust.

posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
@yoshuawuyts yoshuawuyts force-pushed the keyword-generics branch 2 times, most recently from 647dffc to 6d4302e Compare July 25, 2022 11:51
posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
posts/2022-07-25-keyword-generics.md Outdated Show resolved Hide resolved
@yoshuawuyts yoshuawuyts force-pushed the keyword-generics branch 7 times, most recently from 2e1ecd4 to 2dcc298 Compare July 25, 2022 17:47
@yoshuawuyts
Copy link
Member Author

Updated with all feedback! - Also changed to date to tomorrow (Tuesday) to publish as it's getting quite late today.

@yoshuawuyts yoshuawuyts force-pushed the keyword-generics branch 2 times, most recently from 0782217 to a6e2932 Compare July 26, 2022 15:56
@oli-obk
Copy link
Contributor

oli-obk commented Jul 27, 2022

You need to mark it as release: false, that flag is about whether the post is a rust version release, not whether to publish the post.

I can press the merge button, I don't know if I'm allowed to XD who makes the final decision on blog posts?

@Mark-Simulacrum Mark-Simulacrum merged commit a601c3a into master Jul 27, 2022
@Mark-Simulacrum Mark-Simulacrum deleted the keyword-generics branch July 27, 2022 10:58
@yoshuawuyts
Copy link
Member Author

You need to mark it as release: false, that flag is about whether the post is a rust version release, not whether to publish the post.

I don't believe such a flag is needed for the inside Rust blog? Here's the front matter from a previous post, which matches most other posts too:

---
layout: post
title: Rust Compiler June 2022 Steering Cycle
author: Felix Klock
description: "The compiler team's June 2022 steering cycle"
team: The Compiler Team <https://www.rust-lang.org/governance/teams/compiler>
---

I can press the merge button, I don't know if I'm allowed to XD who makes the final decision on blog posts?

My understanding from talking about this with the lang team is that any Rust team can publish to the inside rust blog, as long as it's relevant to the Rust project and we follow proper review etiquette - like we've done. I believe this is the reason why when you're added to a Rust initiative, you get commit access on the blog as well. Ideally this would all be documented in a CONTRIBUTING.md file on the repo, but there is none currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants