Announce change in Cargo.lock policy #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eh2406
reviewed
Aug 25, 2023
|
Wouldn't the better recommendation be to let CI publish the Cargo.lock as an artifact? Having the Cargo.lock committed causes problems with Dependabot and will make CI test against outdated versions, meaning you won't know if your crate even builds properly if someone |
|
Might be better to focus conversations on the policy change to the issue where it was discussed and FCPed, see rust-lang/cargo#8728 |
weihanglo
approved these changes
Aug 25, 2023
epage
commented
Aug 25, 2023
ehuss
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the policy dates back to at least 2017, the Cargo team felt it would be good to ensure there was visibility on this policy change.