Skip to content

Replace .expect() calls with eyre::WrapErr usage #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

Replace .expect() calls with eyre::WrapErr usage #1209

merged 1 commit into from
Jan 18, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 11, 2024

We have proper error handling in the rest of the code now, so we might as well use it here too :)

@Turbo87 Turbo87 mentioned this pull request Jan 11, 2024
Merged
@Turbo87
Copy link
Member Author

Turbo87 commented Jan 18, 2024

r? @rust-lang/website

@Manishearth Manishearth merged commit 96d4bc1 into rust-lang:master Jan 18, 2024
@Turbo87 Turbo87 deleted the expect branch February 1, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @Manishearth