Skip to content

Some minor code cleanup #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Some minor code cleanup #1407

merged 6 commits into from
Jan 22, 2025

Conversation

jfrimmel
Copy link
Contributor

Hey, I've skimmed over the code implementing the blog rendering and found (with the help of clippy, of course) some minor issues. I've prepared this PR, which has individual commits per logical change, so it is easy to remove a commit if a specific change is unwanted. Feel free to request a squash, if this should be only one commit.
Of course, this is a really minor change with no priority at all, so feel free to close.

This fixes all occurences of `clippy::uninlined_format_args`.
This fixes the only occurence of `clippy::default_trait_access`.
This fixes all occurrences of `clippy::redundant_pub_crate`.
This fixes the only occurrence of `clippy::option_if_let_else` and the
only occurrence of `clippy::map_unwrap_or`
Copy link
Contributor

@senekor senekor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the nice commits, this was pleasant to review! 🙂

@senekor senekor merged commit f4a28de into rust-lang:master Jan 22, 2025
3 checks passed
@jfrimmel jfrimmel deleted the clippy branch January 22, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants