Skip to content

Add publish date and author to posts #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2018

Conversation

Aloso
Copy link
Contributor

@Aloso Aloso commented Dec 7, 2018

Fixes issue #308

This is what it looks like:

blog layout

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive
Copy link

warning Warning warning

  • Pull requests are usually filed against the gh-pages branch for this repo, but this one is against master. Please double check that you specified the right target!

@Aloso
Copy link
Contributor Author

Aloso commented Dec 7, 2018

I now also added publish date and author(s) to all blog entries. They are directly under the title, like before. It is formatted like

Jan. 21, 2016 • The Rust Core Team

@Aloso Aloso changed the title Add year and dates to posts on the homepage Add publish date and author to posts Dec 7, 2018
Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks great!

Same question about the git metadata though!

@steveklabnik steveklabnik assigned steveklabnik and unassigned aturon Dec 11, 2018
@Aloso
Copy link
Contributor Author

Aloso commented Dec 11, 2018

The wrong metadata was a mistake.

@steveklabnik steveklabnik merged commit d0015f7 into rust-lang:master Dec 12, 2018
@steveklabnik
Copy link
Member

Thank you!

@Aloso Aloso deleted the year-date-on-homepage branch December 12, 2018 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants