Procedural Macros in Rust 2018 #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @dtolnay, you're likely to have thoughts on this! |
dtolnay
reviewed
Dec 18, 2018
Co-Authored-By: alexcrichton <alex@alexcrichton.com>
Co-Authored-By: alexcrichton <alex@alexcrichton.com>
Co-Authored-By: alexcrichton <alex@alexcrichton.com>
Co-Authored-By: alexcrichton <alex@alexcrichton.com>
Co-Authored-By: alexcrichton <alex@alexcrichton.com>
Co-Authored-By: alexcrichton <alex@alexcrichton.com>
Co-Authored-By: alexcrichton <alex@alexcrichton.com>
Co-Authored-By: alexcrichton <alex@alexcrichton.com>
Co-Authored-By: alexcrichton <alex@alexcrichton.com>
steveklabnik
approved these changes
Dec 18, 2018
| We can then write some unit tests in `tests/smoke.rs`: | ||
|
|
||
| ```rust | ||
| #[my_crate::hello] |
There was a problem hiding this comment.
oooh interesting! So most of our examples so far have had you use hello and then #[hello]. i wonder which style we should encourage
There was a problem hiding this comment.
I don't particularly have a preference either way, but I figured this was a good opportunity to show this off at least.
Co-Authored-By: alexcrichton <alex@alexcrichton.com>
Co-Authored-By: alexcrichton <alex@alexcrichton.com>
Co-Authored-By: alexcrichton <alex@alexcrichton.com>
Co-Authored-By: alexcrichton <alex@alexcrichton.com>
|
Updated with your feedback as well @nrc, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next post lined up after this week's Rust tools in 2018, and I think we'll ideally shoot for publication this Friday if possible!
Rendered