Fix div_duration() marked as stable by mistake #408
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks ;) |
|
I think we usually just fix things without mentioning that they were previously wrong -- maybe it's worth sticking that in a footnote, but not more than that. Could you update the post as such? |
|
Thank you for catching that my previous suggestion had messed-up formatting. In the second commit I moved it down to a footnote at the end instead. I'm not sure if Corrections is self-explanatory enough, but otherwise I think it's good. |
posts/2019-09-26-Rust-1.38.0.md
Outdated
| @@ -95,8 +95,8 @@ Additionally, these functions have been stabilized: | |||
|
|
|||
| - [`<*const T>::cast`] and [`<*mut T>::cast`] | |||
| - [`Duration::as_secs_f32`] and [`Duration::as_secs_f64`] | |||
| - [`Duration::div_duration_f32`] and [`Duration::div_duration_f64`] | |||
| - [`Duration::div_f32`] and [`Duration::div_f64`] | |||
| - EDIT: A Previous version of this post mistakenly marked these as stable. | |||
There was a problem hiding this comment.
As @Mark-Simulacrum noted, no need to retain the "historical record" here -- just remove the incorrect item from the list.
There was a problem hiding this comment.
I'm not quite sure what you mean, I did remove it. I think your looking at the older commit maybe? Sorry, I'm new to github.
No description provided.