Allow team leads posting Inside Rust blog posts #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
approved these changes
Aug 14, 2020
jyn514
reviewed
Aug 14, 2020
|
Well I'm not a team lead, so currently I cannot merge. I think it would still be useful to have the website team on it to be able to correct typos, incorrect metadata, and to merge posts that are approved by working group/project group leads. Though I also don't mind not doing that work, and having that shared amongst the leads as well. |
|
I think doing the work should be separate from being able to approve and merge it. Currently if a team lead fixes a typo, you wouldn't be able to merge it which doesn't seem right. |
|
@jyn514 good point! Reopened rust-lang/core-team#18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows any team lead to approve and merge blog posts for Inside Rust!
r? @nikomatsakis
cc @rust-lang/leads
Closes rust-lang/core-team#18