Skip to content

Announcement that the snapshot branches are moving #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

carols10cents
Copy link
Member

I'm hoping to get this reviewed and posted on Monday, 2022-02-14.

@Eh2406
Copy link

Eh2406 commented Feb 11, 2022

Will removing those branches mean that people have to download the entire index again if the squash has happened since last time they updated? When we did the first squash we tested and incremental downloads were still possible. I hope that's still true.

To clarify.

  1. Clone the master branch
  2. Run a squash
  3. Clone the master branch

When the squashed branches where in repo, step 3 was O(1) not O(size of index). Is this still true?

@bjorn3
Copy link
Member

bjorn3 commented Feb 11, 2022

When the squashed branches where in repo, step 3 was O(1) not O(size of index). Is this still true?

It feels to me like this hasn't been true for quite a while. Not sure though.

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Carol for writing this! There's only one sentence that IMO needs a bit of tweaking.

@Eh2406
Copy link

Eh2406 commented Feb 12, 2022

When the squashed branches where in repo, step 3 was O(1) not O(size of index). Is this still true?

It feels to me like this hasn't been true for quite a while. Not sure though.

The experiments were done before the first squash. That's what we observed at the time. If it had not been working that would also be important information for us to know. But we should collect the evidence, one way or the other.

@jtgeibel
Copy link
Member

With the tweaks suggested by others, the contents of this post looks good to me.

Unfortunately, I'm able to replicate the behavior that @Eh2406 mentions. Without a snapshot branch, git clients will redownload all objects, even if the new HEAD commit points to the exact same tree object. I have a possible idea, but since I think it is off-topic to this particular announcement, I've left that comment at rust-lang/crates.io-index-archive#5 (comment).

carols10cents and others added 2 commits February 13, 2022 08:56
Co-authored-by: Jake Goulding <shepmaster@mac.com>
@carols10cents carols10cents marked this pull request as ready for review February 13, 2022 13:59
@carols10cents carols10cents requested a review from a team February 13, 2022 13:59
@carols10cents
Copy link
Member Author

Ok, I've made all suggested changes and I think this post is ready to go live tomorrow, so this is ready for someone to approve now.

@carols10cents
Copy link
Member Author

carols10cents commented Feb 14, 2022

Ping @rust-lang/core, could someone review and approve this today please? 🙏🏻

Copy link
Member

@badboy badboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal change in the metadata. Otherwise good to go.

On behalf of core: r+

Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>
@carols10cents
Copy link
Member Author

I think someone from core actually has to click the merge button?

@Mark-Simulacrum Mark-Simulacrum merged commit 5b08ffa into rust-lang:master Feb 14, 2022
@carols10cents carols10cents deleted the snapshot-announcement branch February 14, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants