-
Notifications
You must be signed in to change notification settings - Fork 304
Announcement that the snapshot branches are moving #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Announcement that the snapshot branches are moving #925
Conversation
Will removing those branches mean that people have to download the entire index again if the squash has happened since last time they updated? When we did the first squash we tested and incremental downloads were still possible. I hope that's still true. To clarify.
When the squashed branches where in repo, step 3 was |
It feels to me like this hasn't been true for quite a while. Not sure though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Carol for writing this! There's only one sentence that IMO needs a bit of tweaking.
The experiments were done before the first squash. That's what we observed at the time. If it had not been working that would also be important information for us to know. But we should collect the evidence, one way or the other. |
With the tweaks suggested by others, the contents of this post looks good to me. Unfortunately, I'm able to replicate the behavior that @Eh2406 mentions. Without a snapshot branch, git clients will redownload all objects, even if the new HEAD commit points to the exact same tree object. I have a possible idea, but since I think it is off-topic to this particular announcement, I've left that comment at rust-lang/crates.io-index-archive#5 (comment). |
Co-authored-by: Jake Goulding <shepmaster@mac.com>
Ok, I've made all suggested changes and I think this post is ready to go live tomorrow, so this is ready for someone to approve now. |
Ping @rust-lang/core, could someone review and approve this today please? 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minimal change in the metadata. Otherwise good to go.
On behalf of core: r+
Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>
I think someone from core actually has to click the merge button? |
I'm hoping to get this reviewed and posted on Monday, 2022-02-14.