Convert images to SVGs #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sketch can read the SVG source files directly and it's better to have a single source of truth
locks
approved these changes
Jun 28, 2017
|
The image next to the download button is: It's a bit hard to check all svgs with ember's template magic. |
@hannni if you run the dev server you should be able to visit http://localhost:4200/ember-svg-jar/index.html and see all the SVG files in a list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts most of the images in this repository to SVGs based on the contents of the Sketch file and the original PNG files. It also introduces ember-svg-jar, which allows us to use inline SVGs and automatically optimizing them using
svgo.