Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Linux ARPHRD_CAN constant #2077

Closed
wants to merge 1 commit into from

Conversation

fpagliughi
Copy link

The Linux ARPHRD_CAN constant (280) for CANbus appears to be missing.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@JohnTitor
Copy link
Member

Seems some targets' (e.g. Android, Linux) tests need to import linux/if_arp.h.

@fpagliughi
Copy link
Author

OK. I'll have a look.

@JohnTitor
Copy link
Member

@fpagliughi Do you need help? If you're busy I'm happy to work on it instead :)

@JohnTitor
Copy link
Member

@fpagliughi Because we need some test tweaks, I opened #2215 with additional changes, hope you're fine with it. Thanks for the PR anyway!

@bors bors closed this in 1d51906 Jun 3, 2021
@fpagliughi
Copy link
Author

fpagliughi commented Jun 3, 2021

Ha. Yeah, awesome. I wasn't worried about my one line PR, just apologies I didn't follow up. I got bogged down in a couple other projects. Glad it got in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants