Skip to content

Conversation

pinkisemils
Copy link
Contributor

To allow for binding a socket to an interface or querying a socket to see which interface it's bound to, IP_BOUND_IF must be used - I've added it to libc.

I've added it as an apple-wide constant (both for macOS and iOS), but I'm not sure if it's the same value on iOS.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@JohnTitor
Copy link
Member

Could you drop 8712ee3 and open another PR? Otherwise LGTM.

@JohnTitor
Copy link
Member

Thanks!
r? @JohnTitor @bors r+

@bors
Copy link
Contributor

bors commented May 11, 2021

📌 Commit 9434d79 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented May 11, 2021

⌛ Testing commit 9434d79 with merge 065b22c...

@bors
Copy link
Contributor

bors commented May 11, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 065b22c to master...

@bors bors merged commit 065b22c into rust-lang:master May 11, 2021
bors added a commit that referenced this pull request May 25, 2021
Bump version to `0.2.95`

Hiya, I'm eager to use the recently added constant in #2168. Thus, here's a PR to bump the `libc` version to allow a new version to be released.
bors added a commit that referenced this pull request May 25, 2021
Bump version to `0.2.95`

Hiya, I'm eager to use the recently added constant in #2168. Thus, here's a PR to bump the `libc` version to allow a new version to be released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants