Fix type for Android st_nlink #2170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
|
@JohnTitor This changes |
On aarch64[1], arm and x86[2], st_nlink is of type nlink_t (defined as u32). On x86_64, st_nlink is explicitly defined as an unsigned long[3]. [1] https://android.googlesource.com/platform/bionic/+/453076b8d0aaf231a4eec48950530e2bcd774ccd/libc/include/sys/stat.h#48 [2] https://android.googlesource.com/platform/bionic/+/453076b8d0aaf231a4eec48950530e2bcd774ccd/libc/include/sys/stat.h#87 [3] https://android.googlesource.com/platform/bionic/+/453076b8d0aaf231a4eec48950530e2bcd774ccd/libc/include/sys/stat.h#67
|
Actually these are already unsigned, so this isn't a breaking change. @bors r+ |
|
📌 Commit 6055dcb has been approved by |
|
💔 Test failed - checks-actions |
|
@bors retry |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.