Run pkg-config on macOS.
#112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `pkg-config zlib` does not print `-L /usr/lib` for any zlib package that I'm aware of on macOS (not even the one provided by Apple). Moreover, the comment about a `-L /usr/lib` flag wreaking havoc on attempting to link with OpenSSL in `/usr/local/lib` should no longer be true. Presumbly, this was the case when Apple shipped its own `libcrypto` and `libssl` in `/usr/lib`, but those days are long gone.
|
Is that true for tvOS and/or iOS? the |
|
It should be, yes. I'm not sure Apple ever even shipped a |
JohnTitor
approved these changes
Apr 23, 2023
|
Thank you for clarifying! Let's ship this then, this was introduced in 043a4cd, but I think it's the old macOS's issue and I'm going to revert if that issue still exists on any of the supported macOS. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
pkg-config zlibdoes not print-L /usr/libfor any zlibpackage that I'm aware of on macOS (not even the one provided by Apple).
Moreover, the comment about a
-L /usr/libflag wreaking havoc onattempting to link with OpenSSL in
/usr/local/libshould no longer betrue. Presumbly, this was the case when Apple shipped its own
libcryptoandlibsslin/usr/lib, but those days are long gone.