Skip to content

corrected introduction to macros in macros.md #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2018
Merged

corrected introduction to macros in macros.md #467

merged 1 commit into from
Dec 6, 2018

Conversation

Zaechus
Copy link
Contributor

@Zaechus Zaechus commented Nov 18, 2018 •
edited
Loading

The previous introduction to macros incorrectly stated the purpose of macros in Rust. I modified the intro to more appropriately introduce this feature.
Fixes #152

Centril
Centril approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; this seems more to the point, more factual and less judgemental.

@Centril Centril merged commit 01e21c1 into rust-lang:master Dec 6, 2018
@chriskrycho chriskrycho mentioned this pull request Jan 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Centril Centril Centril approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zaechus @Centril