Skip to content

Document extern_crate_item_prelude #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2019
Merged

Document extern_crate_item_prelude #509

merged 4 commits into from
Jan 13, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jan 13, 2019 •
edited
Loading

Centril
Centril reviewed Jan 13, 2019
View reviewed changes
petrochenkov
petrochenkov reviewed Jan 13, 2019
View reviewed changes
Centril and others added 2 commits January 13, 2019 10:59
@Centril @ehuss
Clarify not "renamed".
15fc5d5 
Co-Authored-By: ehuss <eric@huss.org>
@Centril @ehuss
Apply suggestions from code review
fc251f9 
Co-Authored-By: ehuss <eric@huss.org>
Havvy
Havvy reviewed Jan 13, 2019
View reviewed changes
Copy link
Contributor

@Havvy Havvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The no_std attribute is only usable on the crate root and is stated there already, so adding it here is redundant.

@Centril
Copy link
Contributor

Centril commented Jan 13, 2019

Looks good; thanks!

@Centril Centril merged commit 1c775a1 into rust-lang:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
4 more reviewers

@Havvy Havvy Havvy left review comments

@Centril Centril Centril left review comments

@petrochenkov petrochenkov petrochenkov left review comments

@matthewjasper matthewjasper matthewjasper approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ehuss @Centril @Havvy @petrochenkov @matthewjasper