Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regex-syntax: update to Unicode 10.0 #400

Merged
merged 2 commits into from
Sep 27, 2017
Merged

regex-syntax: update to Unicode 10.0 #400

merged 2 commits into from
Sep 27, 2017

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Sep 7, 2017

Fixes #391

The `#![cfg_attr(test, deny(warnings))]` caused CI failures from
`error: variable does not need to be mutable`, which would otherwise
just be a warning.  Every case here is simply binding a `&mut`, so the
variables themselves indeed don't need to be mutable.
@BurntSushi
Copy link
Member

@cuviper Nice! Thanks. @bors r+

@bors
Copy link
Contributor

bors commented Sep 27, 2017

📌 Commit 2131b40 has been approved by BurntSushi

bors added a commit that referenced this pull request Sep 27, 2017
regex-syntax: update to Unicode 10.0

Fixes #391
@bors
Copy link
Contributor

bors commented Sep 27, 2017

⌛ Testing commit 2131b40 with merge af2c105...

@bors
Copy link
Contributor

bors commented Sep 27, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: BurntSushi
Pushing af2c105 to master...

@bors bors merged commit 2131b40 into rust-lang:master Sep 27, 2017
cuviper added a commit to cuviper/regex that referenced this pull request Jun 11, 2018
This adds `scripts/generate.py`, and uses it to regenerate all tables
with data from Unicode 11.0.0.  This also restores the character tests
that were first added in rust-lang#400, with a new one for 11.
BurntSushi pushed a commit that referenced this pull request Jun 12, 2018
This adds `scripts/generate.py`, and uses it to regenerate all tables
with data from Unicode 11.0.0.  This also restores the character tests
that were first added in #400, with a new one for 11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants