unused_unit: small clean-up
#15550
Merged
unused_unit: small clean-up
#15550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Their default branches are even the same, which means that one of the `map_or`s could've been replaced with an `and_then`, but since we have access to let-chains, why not use that Additionally: - use `with_source_text` to avoid constructing a `SourceText` object - use `BytePos::from_usize` to avoid `allow`ing the lint
Avoids needless bounds checks (which almost definitely get optimized away, but still). And saves some characters
rustbot
added
the
S-waiting-on-review
|
oops, forgot to |
|
I extracted the message from the top-level comment since it will be present in the merge commit description. It was:
|
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none