Skip to content

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Aug 25, 2025

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 25, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 25, 2025
@ada4a
Copy link
Contributor Author

ada4a commented Aug 25, 2025

r? clippy

@rustbot rustbot assigned blyxyas and unassigned Alexendoo Aug 25, 2025
@ada4a ada4a force-pushed the future-not-send-cleanup branch from 03ed395 to fcfad7f Compare August 25, 2025 16:00
@ada4a ada4a force-pushed the future-not-send-cleanup branch from fcfad7f to d908051 Compare August 25, 2025 16:36
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really gentle contribution, just a nit

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Sep 6, 2025
@ada4a ada4a force-pushed the future-not-send-cleanup branch from d908051 to fe86ce6 Compare September 6, 2025 22:14
@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ada4a
Copy link
Contributor Author

ada4a commented Sep 6, 2025

Sneaked in another simplification (imo) while at it, do let me know if it's okay to leave in

EDIT: Uhh, the range-diff came out kind of funky -- the actual change isn't like that 😅

@ada4a
Copy link
Contributor Author

ada4a commented Sep 9, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Sep 9, 2025
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️ nice cleanup

View changes since this review

@blyxyas blyxyas added this pull request to the merge queue Sep 11, 2025
Merged via the queue into rust-lang:master with commit 2108f03 Sep 11, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 11, 2025
@ada4a ada4a deleted the future-not-send-cleanup branch September 11, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants