Skip to content

Conversation

smoelius
Copy link
Contributor

The things being separated are sentences. So I think semicolons are the right separators to use.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 30, 2025
@blyxyas
Copy link
Member

blyxyas commented Aug 30, 2025

Why is this change to an internal disallowed-methods config "hypercritical" (which I interpret to be "very important with real consequences")

@smoelius
Copy link
Contributor Author

I meant that I am being super pedantic. (Sorry for my ill attempt at humor.)

@samueltardieu
Copy link
Member

The title and the main comment of a PR stay forever in the Clippy and the Rust compiler versioning system once the PR is merged. That may not be the place to put jokes or sarcasm as it may be later read without the context.

@smoelius smoelius changed the title Hypercritical change: commas to semicolons in clippy.toml reasons Commas to semicolons in clippy.toml reasons Aug 30, 2025
@smoelius
Copy link
Contributor Author

The title and the main comment of a PR stay forever in the Clippy and the Rust compiler versioning system once the PR is merged. That may not be the place to put jokes or sarcasm as it may be later read without the context.

Your point is well taken. I've re-titled the PR. My sincerest apologies.

Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

View changes since this review

@blyxyas
Copy link
Member

blyxyas commented Aug 31, 2025

(Sorry for my ill attempt at humor.)

No worries, it's just that I'm not used to sarcasm in PR titles. Thanks for the contribution!

@blyxyas blyxyas added this pull request to the merge queue Aug 31, 2025
Merged via the queue into rust-lang:master with commit 034136d Aug 31, 2025
13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants