Skip to content

Remove expect collapsible_span_lint_calls and use span_lint_and_help #15612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2025
Merged

Remove expect collapsible_span_lint_calls and use span_lint_and_help #15612

merged 1 commit into from
Sep 13, 2025

Conversation

alex-semenyuk
Copy link
Member

@alex-semenyuk alex-semenyuk commented Sep 4, 2025 •
edited by blyxyas
Loading

Remove expected collapsible_span_lint_calls and use span_lint_and_help since #7698 was resolved

changelog:none

@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 4, 2025
@blyxyas
Copy link
Member

blyxyas commented Sep 13, 2025

As this isn't a user-facing change, it doesn't need a changelog. Btw, we should probably look into making the lint forbid

blyxyas
blyxyas approved these changes Sep 13, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️ =^w^= Have a great day

View changes since this review

@blyxyas blyxyas added this pull request to the merge queue Sep 13, 2025
Merged via the queue into rust-lang:master with commit 544e24a Sep 13, 2025
18 of 19 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-semenyuk @rustbot @blyxyas