clean-up match_same_arms a bit
#15727
Conversation
rustbot
added
the
S-waiting-on-review
| .map(|(_, arm)| snippet_opt(cx, arm.pat.span)) | ||
| .collect::<Option<Vec<_>>>() | ||
| { | ||
| let mut suggs = src | ||
| let suggs = src | ||
| .iter() | ||
| .map(|(_, arm)| (adjusted_arm_span(cx, arm.span), String::new())) | ||
| .chain([(dest.pat.span, pat_snippets.iter().join(" | "))]) |
There was a problem hiding this comment.
snippet_opt is probably going to be removed at some point. Note that get_source_text does not allocate a temporary string.
There was a problem hiding this comment.
Right, I remember hearing something like that. Would it make sense to mark snippet_opt as #[deprecated] then?
There was a problem hiding this comment.
That's waiting on a cleanup PR to be merged.
That isn't really doable without an annoyingly large number of allows.
There was a problem hiding this comment.
Why allows? Can't one basically always replace snippet_opt with get_source_text? Well unless you do need a String, but that's just an added .to_owned()
There was a problem hiding this comment.
if all the uses are going to be replaced then it can just be removed instead of deprecated.
ada4a
force-pushed
the
match-same-arms
branch
from
eb29c32 to
f76664c
Compare
rustbot
removed
the
S-waiting-on-review
changelog: none