Do not suggest using a if let chain if it is not supported
#15746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
issues/15744
branch
from
79b9982 to
fb0c455
Compare
|
Lintcheck changes for f107991
This comment will be updated if you push new changes |
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
issues/15744
branch
from
fb0c455 to
2659fae
Compare
This comment has been minimized.
This comment has been minimized.
samueltardieu
force-pushed
the
issues/15744
branch
from
2659fae to
1477470
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
blyxyas
approved these changes
Sep 30, 2025
This might be due to a low edition (< 2024) or too low a MSRV.
samueltardieu
force-pushed
the
issues/15744
branch
from
1477470 to
f107991
Compare
Done. |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be due to a low edition (< 2024) or too low a MSRV. In this case, we will suggest only
match.Fixes #15744
changelog: [
unnecessary_unwrap]: do not suggest usingif letchains if this is not supported with the current edition or MSRVchangelog:[
collapsible_if]: Do not suggest usingif letif this is not supported with the current edition or MSRV