Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split redundant_closure lint #4101

Merged
merged 4 commits into from May 16, 2019

Conversation

Projects
None yet
4 participants
@mikerite
Copy link
Contributor

commented May 16, 2019

Move the method checking into a new lint called
redundant_closures_for_method_calls and put it in the pedantic group.

This aspect of the lint seems more controversial than the rest.

cc #3942

changelog: Move method checking from redundant_closure to a new pedantic lint called redundant_closure_for_method_calls.

Split redundant_closure lint
Move the method checking into a new lint called
`redundant_closures_for_method_calls` and put it in the pedantic group.

This aspect of the lint seems more controversial than the rest.

cc #3942
@mikerite

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

I'm not sure if we actually decided to do this but it was mentioned as a possibility by @Manishearth in #3942 (comment) .

@Manishearth
Copy link
Member

left a comment

r+, unsure if the name should be so long. Also I'd like another person to verify we want this (@flip1995, @matthiaskrgr?)

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented May 16, 2019

I think splitting those lints is the correct thing to do. There are too many FPs and annoyances that aren't trivial to fix. I would add to the changelog, that the new lint is in the pedantic group though. "to a new lint" -> "to a new pedantic lint"


As for the name: I can't come up with a shorter name. But I would keep the singular form from the previous lint: redundant_closures_for_method_calls

@Manishearth

This comment has been minimized.

Copy link
Member

commented May 16, 2019

We might want to beta backport this

@Manishearth

This comment has been minimized.

Copy link
Member

commented May 16, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

📌 Commit f1f1940 has been approved by Manishearth

@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

⌛️ Testing commit f1f1940 with merge d0b0a3c...

bors added a commit that referenced this pull request May 16, 2019

Auto merge of #4101 - mikerite:redundant_closures_for_method_calls, r…
…=Manishearth

Split redundant_closure lint

Move the method checking into a new lint called
`redundant_closures_for_method_calls` and put it in the pedantic group.

This aspect of the lint seems more controversial than the rest.

cc #3942

changelog: Move method checking from `redundant_closure` to a new `pedantic` lint called `redundant_closures_for_method_calls`.

@Manishearth Manishearth force-pushed the mikerite:redundant_closures_for_method_calls branch from f1f1940 to 373d270 May 16, 2019

@Manishearth

This comment has been minimized.

Copy link
Member

commented May 16, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

📌 Commit 373d270 has been approved by Manishearth

bors added a commit that referenced this pull request May 16, 2019

Auto merge of #4101 - mikerite:redundant_closures_for_method_calls, r…
…=Manishearth

Split redundant_closure lint

Move the method checking into a new lint called
`redundant_closures_for_method_calls` and put it in the pedantic group.

This aspect of the lint seems more controversial than the rest.

cc #3942

changelog: Move method checking from `redundant_closure` to a new `pedantic` lint called `redundant_closure_for_method_calls`.
@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

⌛️ Testing commit 373d270 with merge b30f8fd...

@Manishearth

This comment has been minimized.

Copy link
Member

commented May 16, 2019

We may want to beta backport this so it's in the stable release next week. This will probably have to be rewritten from scratch, though.

@Manishearth

This comment has been minimized.

Copy link
Member

commented May 16, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

📌 Commit ce63f3a has been approved by Manishearth

bors added a commit that referenced this pull request May 16, 2019

Auto merge of #4101 - mikerite:redundant_closures_for_method_calls, r…
…=Manishearth

Split redundant_closure lint

Move the method checking into a new lint called
`redundant_closures_for_method_calls` and put it in the pedantic group.

This aspect of the lint seems more controversial than the rest.

cc #3942

changelog: Move method checking from `redundant_closure` to a new `pedantic` lint called `redundant_closure_for_method_calls`.
@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

⌛️ Testing commit ce63f3a with merge aa3eb07...

Manishearth added a commit to Manishearth/rust-clippy that referenced this pull request May 16, 2019

Backport rust-lang#4101
rust-lang#4101

Splits up redundant_closure's method checking into a pedantic lint
@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

💔 Test failed - status-appveyor

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented May 16, 2019

@bors r=Manishearth

@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

📌 Commit 08d2a0d has been approved by Manishearth

bors added a commit that referenced this pull request May 16, 2019

Auto merge of #4101 - mikerite:redundant_closures_for_method_calls, r…
…=Manishearth

Split redundant_closure lint

Move the method checking into a new lint called
`redundant_closures_for_method_calls` and put it in the pedantic group.

This aspect of the lint seems more controversial than the rest.

cc #3942

changelog: Move method checking from `redundant_closure` to a new `pedantic` lint called `redundant_closure_for_method_calls`.
@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

⌛️ Testing commit 08d2a0d with merge 11194e3...

@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing 11194e3 to master...

@bors bors merged commit 08d2a0d into rust-lang:master May 16, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details

@Manishearth Manishearth referenced this pull request May 16, 2019

Merged

Update clippy #60887

Manishearth added a commit to Manishearth/rust-clippy that referenced this pull request May 16, 2019

Backport rust-lang#4101
rust-lang#4101

Splits up redundant_closure's method checking into a pedantic lint

Manishearth added a commit to Manishearth/rust-clippy that referenced this pull request May 17, 2019

Backport rust-lang#4101
rust-lang#4101

Splits up redundant_closure's method checking into a pedantic lint

Manishearth added a commit to Manishearth/rust-clippy that referenced this pull request May 17, 2019

Backport rust-lang#4101
rust-lang#4101

Splits up redundant_closure's method checking into a pedantic lint

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk

flip1995 added a commit to Manishearth/rust-clippy that referenced this pull request May 17, 2019

Backport rust-lang#4101
rust-lang#4101

Splits up redundant_closure's method checking into a pedantic lint

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk

oli-obk added a commit to Manishearth/rust-clippy that referenced this pull request May 17, 2019

Backport rust-lang#4101
rust-lang#4101

Splits up redundant_closure's method checking into a pedantic lint

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=flip1995
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=flip1995
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk

Manishearth added a commit to Manishearth/rust that referenced this pull request May 17, 2019

@Manishearth Manishearth referenced this pull request May 17, 2019

Merged

[beta] Update clippy #60918

bors added a commit to rust-lang/rust that referenced this pull request May 18, 2019

@mikerite mikerite deleted the mikerite:redundant_closures_for_method_calls branch May 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.