Skip to content

Conversation

apiraino
Copy link
Contributor

Discoveredf another label that wasn't filtered out in the list of issues/pr not assigned to a team.

Old version of T-libs filtering labels: -label:T-libs -label:T-libs-impl
After this patch: -label:T-libs -label:T-libs-impl -label:T-libs-api

r? @spastorino

@spastorino
Copy link
Member

@apiraino those are part of a re-structure @rust-lang/libs team had. @m-ou-se can you guide @apiraino about the right labels to use?

@m-ou-se
Copy link
Member

m-ou-se commented Jun 17, 2021

  • T-libs was renamed to T-libs-api
  • T-libs-impl was renamed to T-libs

So, before we had a generic libs label and a specific label for implementation issues. Now we have a generic libs label and a specific one for the api issues.

@m-ou-se
Copy link
Member

m-ou-se commented Jun 17, 2021

Or maybe this is clearer:

let t_libs_api = std::mem::replace(&mut t_libs, t_libs_impl);

@apiraino
Copy link
Contributor Author

r? @spastorino I think I have addressed the comment

@spastorino spastorino merged commit eb87a00 into rust-lang:master Jun 18, 2021
@apiraino apiraino deleted the add-t-libs-api-label branch June 20, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants