Add travis config (and make tests runnable on emacs 23) #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit a8fad0f broke the ERT tests by removing trailing whitespace inside the test strings. Fix the tests, and replace some line endings inside strings with explicit "\n" to avoid having further significant trailing whitespace in the code.
The new recommended style is to use the "cl-" prefixed versions, but they do not exist in emacs 23. We still want to stay compatible with that, so use plain "loop" rather than "cl-loop" to allow the tests to work with both old and new versions. ALso "pcase" was introduced in emacs 24, so stop using it to remain compatible with emacs 23.
|
This looks pretty reasonable, and it'd be awesome to have travis running the unit tests. |
nikomatsakis
added a commit
that referenced
this pull request
Feb 6, 2015
Add travis config (and make tests runnable on emacs 23)
|
@MicahChalmer what else is needed to get travis going? |
|
All it needs now is for someone with admin access on this repo to go to travis-ci.org and flip the switch. |
|
Done. |
|
Looks like it works great, thanks @MicahChalmer: #24, https://travis-ci.org/rust-lang/rust-mode/builds/49740310 (tests seem to fail on emac23?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bit more to this than I initially expected...
The rust-mode code has a few things in it that show intent to keep it compatible with emacs 23 as well as emacs 24, so the
.travis.ymlfile here tests it against emacs 23, 24 and the latest snapshot build. To make it successfully test on emacs 23 I had to change the test code (though not the actual rust-mode code under test) to eliminate some use of forms that were newly introduced in emacs 24.The way it installs emacs in the Travis VM is taken from the example at https://github.com/rolandwalker/emacs-travis. Other repos seem using the same approach as well--a very well known one is Magit.
There are a few unfortunate things about it:
An alternative approach would be to have it download an emacs source tarball right from a GNU mirror, and rebuild emacs from source each time. That would eliminate dependency on no-longer-interested third parties, but would also complicate the configuration in this repo and might make the travis builds take a while. (I haven't tried it, so I can't really say for sure.)
Here is a successful Travis run with this version from my own fork.