Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: ICE -- no type for node #100541

Closed
Mark-Simulacrum opened this issue Aug 14, 2022 · 6 comments
Closed

regression: ICE -- no type for node #100541

Mark-Simulacrum opened this issue Aug 14, 2022 · 6 comments
Labels
I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Aug 14, 2022

Picked up in crater:

@Mark-Simulacrum Mark-Simulacrum added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Aug 14, 2022
@Mark-Simulacrum Mark-Simulacrum added this to the 1.64.0 milestone Aug 14, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Aug 14, 2022
@Mark-Simulacrum Mark-Simulacrum added the E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example label Aug 14, 2022
@compiler-errors
Copy link
Member

This is fixed by #100155

@compiler-errors
Copy link
Member

Should I backport that? Or is the fact that the code failed to compile not enough to warrant nominating it?

@Mark-Simulacrum Mark-Simulacrum removed E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Aug 14, 2022
@Mark-Simulacrum
Copy link
Member Author

I think given that we have only 1 case detected by Crater a backport doesn't seem necessary, but it's also a small PR. No strong opinion.

@compiler-errors
Copy link
Member

I'll do it. It's very possible that people can trigger it while doing a refactor, for example.

@Mark-Simulacrum
Copy link
Member Author

Yeah, I think I saw a few more cases as well (outside of just this one root regression according to Crater).

@pietroalbini
Copy link
Member

Fix backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants