Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::os::wasi::io::AsFd regression on Rust 1.64 #103306

Closed
sunfishcode opened this issue Oct 20, 2022 · 0 comments · Fixed by #103308
Closed

std::os::wasi::io::AsFd regression on Rust 1.64 #103306

sunfishcode opened this issue Oct 20, 2022 · 0 comments · Fixed by #103308
Labels
C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@sunfishcode
Copy link
Member

I tried this code:

#![allow(unused_imports)]

use std::os::wasi::io::AsFd;

I expected to see this happen: it compiles

Instead, this happened:

With Rust 1.63, it compiles. With Rust 1.64 and Rust nightly, it gets this error:

error[E0658]: use of unstable library feature 'wasi_ext'
 --> src/lib.rs:3:5
  |
3 | use std::os::wasi::io::AsFd;
  |     ^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: see issue #71213 <https://github.com/rust-lang/rust/issues/71213> for more information
@sunfishcode sunfishcode added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. C-bug Category: This is a bug. labels Oct 20, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 20, 2022
@sunfishcode sunfishcode mentioned this issue Oct 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 21, 2022
@bors
Auto merge of rust-lang#103308 - sunfishcode:sunfishcode/wasi-io-safe…
b1ab3b7 
…ty, r=joshtriplett

Mark `std::os::wasi::io::AsFd` etc. as stable.

io_safety was stabilized in Rust 1.63, so mark the io_safety exports in `std::os::wasi::io` as stable.

Fixes rust-lang#103306.
@bors bors closed this as completed in e56b84e Oct 21, 2022
@apiraino apiraino added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Oct 21, 2022
lyming2007 pushed a commit to lyming2007/rust that referenced this issue Oct 21, 2022
@sunfishcode
Mark std::os::wasi::io::AsFd etc. as stable.
51df6cc 
io_safety was stabilized in Rust 1.63, so mark the io_safety exports in
`std::os::wasi::io` as stable.

Fixes rust-lang#103306.
Mark-Simulacrum pushed a commit to Mark-Simulacrum/rust that referenced this issue Oct 29, 2022
@sunfishcode @Mark-Simulacrum
Mark std::os::wasi::io::AsFd etc. as stable.
002ce8c 
io_safety was stabilized in Rust 1.63, so mark the io_safety exports in
`std::os::wasi::io` as stable.

Fixes rust-lang#103306.
@messense messense mentioned this issue Dec 6, 2022
Merged
@waywardmonkeys waywardmonkeys mentioned this issue Aug 9, 2023
Merged
waywardmonkeys added a commit to waywardmonkeys/criterion.rs that referenced this issue Aug 10, 2023
@waywardmonkeys
ci: Disable wasi test except on stable.
716ae36 
This results in an error when building with 1.64 despite `AsFd`
having been added in 1.63. It was fixed in 1.66:

rust-lang/rust#103306
lemmih pushed a commit to bheisler/criterion.rs that referenced this issue Aug 10, 2023
@waywardmonkeys
Update CI (#707)
bb44f0b 
* plot/Cargo.toml: Remove outdated CI badges.

crates.io doesn't support this and they're outdated anyway.

* ci: Update actions.

Use `actions/checkout@v3` to remove a warning about old versions
of node.

Use `dtolay/rust-toolchain` instead of `actions-rs/toolchain` as
it is maintained (and `actions-rs` actions are not). This also
resolves a number of warnings about deprecated functionality
within the GitHub Actions UI.

Update one usage of `Swatimem/rust-cache` to v2. The other
already was updated.

Use `cargo` directly instead of using `actions-rs/cargo` as that
action is also unmaintained.

* ci: Disable wasi test except on stable.

This results in an error when building with 1.64 despite `AsFd`
having been added in 1.63. It was fixed in 1.66:

rust-lang/rust#103306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark std::os::wasi::io::AsFd etc. as stable. sunfishcode/rust
3 participants
@sunfishcode @apiraino @rustbot