Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc should render the body of assoc tys *before* the where-clause #112903

Closed
fmease opened this issue Jun 21, 2023 · 0 comments · Fixed by #112906
Closed

rustdoc should render the body of assoc tys *before* the where-clause #112903

fmease opened this issue Jun 21, 2023 · 0 comments · Fixed by #112906
Assignees
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@fmease
Copy link
Member

fmease commented Jun 21, 2023

Given

pub struct S;

pub trait Tr {
    type F<T>
    where
        T: Clone;
}

impl Tr for S {
    type F<T> = T
    where
        T: Clone;
}

rustdoc currently renders the body of the associated type F, namely T, after the where-clause which no longer aligns with the recommended style (see #89122, lint deprecated_where_clause_location):

Screenshot 2023-06-21 at 20-29-16 Tr in nx - Rust

@rustbot claim
@rustbot label C-bug T-rustdoc A-rustdoc-ui

@rustbot rustbot added A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 21, 2023
@bors bors closed this as completed in 3ba66df Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants