-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: concrete type differs from previous defining opaque type use #115781
Comments
this regressed in 0dd5730:
The exact commit is not available anymore ( |
WG-prioritization assigning priority (Zulip discussion). @rustbot label -I-prioritize +P-medium |
hmm... that PR was only supposed to fix a type_alias_impl_trait unsoundness, not have any effect on stable crates and RPIT. I'll investigate |
… r=jackh726 Paper over an accidental regression r? types cc rust-lang#115781 (do not close issue until beta backport has been performed) The PR reasons are explained with comments in the source. In order to keep the diff simple, this PR effectively reverts rust-lang#113661, but only for RPITs. I will submit a follow up PR that fixes this correctly instead of just disabling the newly added check for RPITs. This PR should be significantly easier to review for beta backport
Rollup merge of rust-lang#115844 - oli-obk:opaque_lifetime_ambiguity, r=jackh726 Paper over an accidental regression r? types cc rust-lang#115781 (do not close issue until beta backport has been performed) The PR reasons are explained with comments in the source. In order to keep the diff simple, this PR effectively reverts rust-lang#113661, but only for RPITs. I will submit a follow up PR that fixes this correctly instead of just disabling the newly added check for RPITs. This PR should be significantly easier to review for beta backport
beta backported a fix in #116044 |
https://crater-reports.s3.amazonaws.com/beta-1.73-1.2/beta-2023-09-10/reg/tree-sitter-graph-0.11.0/log.txt
The text was updated successfully, but these errors were encountered: