-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enum variants are always exported cross-crate #11680
Comments
The above works (i.e. fails to compile) intra-crate, except then we can't make mod foo {
enum Private { pub Public }
}
fn main() { foo::Public; } complains about |
Nominating, this is a backwards compatibility hazard. |
Assigning 1.0 milestone, P-backcompat-lang. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
May 6, 2014
The code in resolve erroneously assumed that private enums weren't visited, so the logic was adjusted to check to see if the enum definition itself was public. Closes rust-lang#11680
bors
added a commit
that referenced
this issue
May 9, 2014
The code in resolve erroneously assumed that private enums weren't visited, so the logic was adjusted to check to see if the enum definition itself was public. Closes #11680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The above compiles fine, and, adding an explicit
priv
toBar
emits an error about unnecessarypriv
.The text was updated successfully, but these errors were encountered: