Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crater runs for 1.77 #120894

Closed
Mark-Simulacrum opened this issue Feb 10, 2024 · 21 comments
Closed

Crater runs for 1.77 #120894

Mark-Simulacrum opened this issue Feb 10, 2024 · 21 comments
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Milestone
1.77.0

Comments

@Mark-Simulacrum
Copy link
Member

Note: Please do not conduct triage on these runs without discussing how to do so with a release team member first. Thanks!
@Mark-Simulacrum Mark-Simulacrum added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Feb 10, 2024
@Mark-Simulacrum Mark-Simulacrum added this to the 1.77.0 milestone Feb 10, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 10, 2024
@Mark-Simulacrum
Copy link
Member Author

@craterbot run name=beta-1.77-1 start=1.76.0 end=beta-2024-02-10 mode=build-and-test cap-lints=warn p=1

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.77-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Feb 10, 2024
@Mark-Simulacrum
Copy link
Member Author

@craterbot run name=beta-1.77-rustdoc-1 start=1.76.0 end=beta-2024-02-10 mode=rustdoc cap-lints=warn p=1

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.77-rustdoc-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 10, 2024
@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.77-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.77-rustdoc-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.77-1 is completed!
📊 271 regressed and 168 fixed (416080 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 15, 2024
@Mark-Simulacrum
Copy link
Member Author

@craterbot run name=beta-1.77-2 start=1.76.0 end=beta-2024-02-13 mode=build-and-test cap-lints=warn p=1 crates=https://crater-reports.s3.amazonaws.com/beta-1.77-1/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.77-2 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2024
@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.77-2 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.77-rustdoc-1 is completed!
📊 55 regressed and 23 fixed (416080 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 16, 2024
@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.77-2 is completed!
📊 142 regressed and 15 fixed (271 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member Author

@craterbot run name=beta-1.77-3 start=1.76.0 end=beta-2024-02-18 mode=build-and-test cap-lints=warn p=1 crates=https://crater-reports.s3.amazonaws.com/beta-1.77-2/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.77-3 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2024
@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.77-3 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.77-3 is completed!
📊 127 regressed and 4 fixed (142 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Feb 20, 2024
@craterbot craterbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2024
@Mark-Simulacrum
Copy link
Member Author

@Mark-Simulacrum
Copy link
Member Author

@craterbot run name=beta-1.77-rustdoc-2 start=1.76.0 end=beta-2024-02-18 mode=rustdoc cap-lints=warn p=1 crates=https://crater-reports.s3.amazonaws.com/beta-1.77-rustdoc-1/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.77-rustdoc-2 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2024
@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.77-rustdoc-2 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.77-rustdoc-2 is completed!
📊 44 regressed and 0 fixed (55 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 26, 2024
@saethlin saethlin mentioned this issue Mar 9, 2024
Merged
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Mar 12, 2024
@workingjubilee
Rollup merge of rust-lang#122245 - saethlin:check-dep-graph-size, r=p…
f54350a 
…etrochenkov

Detect truncated DepGraph files

I suspect that the following issues are caused by truncated incr comp files:

* rust-lang#120582
* rust-lang#121499
* rust-lang#122210

We fail with an allocation failure or capacity overflow in this case because we assume that the ending bytes of an DepGraph file are the lengths of arrays. If the file has somehow been truncated then the ending bytes are probably some of our varint encoding, which tries to eliminate zero bytes, so interpreting a random 8 bytes as an array length has a very high chance of producing a byte capacity over `isize::MAX`.

Now theoretically since rust-lang#119510 merged I have fixed the out-of-disk issues and yet in rust-lang#120894 (comment) I still see some decoding failures that look like out-of-disk ICEs, for example https://crater-reports.s3.amazonaws.com/beta-1.77-1/beta-2024-02-10/gh/scottfones.aoc_2022/log.txt

So this PR should ensure that we get an ICE that clearly identifies if the file in question is truncated.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 12, 2024
@rust-timer
Unrolled build for rust-lang#122245
15aa49b 
Rollup merge of rust-lang#122245 - saethlin:check-dep-graph-size, r=petrochenkov

Detect truncated DepGraph files

I suspect that the following issues are caused by truncated incr comp files:

* rust-lang#120582
* rust-lang#121499
* rust-lang#122210

We fail with an allocation failure or capacity overflow in this case because we assume that the ending bytes of an DepGraph file are the lengths of arrays. If the file has somehow been truncated then the ending bytes are probably some of our varint encoding, which tries to eliminate zero bytes, so interpreting a random 8 bytes as an array length has a very high chance of producing a byte capacity over `isize::MAX`.

Now theoretically since rust-lang#119510 merged I have fixed the out-of-disk issues and yet in rust-lang#120894 (comment) I still see some decoding failures that look like out-of-disk ICEs, for example https://crater-reports.s3.amazonaws.com/beta-1.77-1/beta-2024-02-10/gh/scottfones.aoc_2022/log.txt

So this PR should ensure that we get an ICE that clearly identifies if the file in question is truncated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

No branches or pull requests
4 participants
@Mark-Simulacrum @saethlin @craterbot @rustbot