Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change wf.rs to use a TypeVisitor instead of walk #121693

Closed
lcnr opened this issue Feb 27, 2024 · 1 comment · Fixed by #122150
Closed

change wf.rs to use a TypeVisitor instead of walk #121693

lcnr opened this issue Feb 27, 2024 · 1 comment · Fixed by #122150
Assignees
@ShoyuVanilla
Labels
A-traits Area: Trait system C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-types Relevant to the types team, which will review and decide on the PR/issue.

Comments

@lcnr
Copy link
Contributor

lcnr commented Feb 27, 2024 •
edited by rustbot
Loading

we should change the following function to use a TypeVisitor instead of walk

rust/compiler/rustc_trait_selection/src/traits/wf.rs

Line 512 in b6e4299

fn compute(&mut self, arg: GenericArg<'tcx>) {

Using a walker causes the control-flow to be a lot more complicated and given that this code is soundness-critical, we should make sure it's as easy to understand as possible
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 27, 2024
@lcnr lcnr added C-cleanup Category: PRs that clean code up or issues documenting cleanup. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 27, 2024
@jieyouxu jieyouxu added A-traits Area: Trait system T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 27, 2024
@compiler-errors compiler-errors added T-types Relevant to the types team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 27, 2024
@ShoyuVanilla
Copy link
Member

@rustbot claim

@ShoyuVanilla ShoyuVanilla mentioned this issue Mar 7, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 8, 2024
@bors
Auto merge of rust-lang#122150 - ShoyuVanilla:replace-typewalker, r=<…
96b719d 
…try>

Replace `TypeWalker` usage with `TypeVisitor` in `wf.rs`

Resolves rust-lang#121693
@bors bors closed this as completed in b054da8 Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShoyuVanilla ShoyuVanilla

Labels
A-traits Area: Trait system C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace TypeWalker usage with TypeVisitor in wf.rs ShoyuVanilla/rust
5 participants
@compiler-errors @ShoyuVanilla @lcnr @jieyouxu @rustbot