Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out the definition ord Ord/Eq, TotalOrd/TotalEq #12579

Closed
brson opened this issue Feb 26, 2014 · 2 comments
Closed

Figure out the definition ord Ord/Eq, TotalOrd/TotalEq #12579

brson opened this issue Feb 26, 2014 · 2 comments

Comments

@brson
Copy link
Contributor

brson commented Feb 26, 2014

I see all kinds of issues that propose specific solutions, but none that are still opened. We need to be happy with these traits for 1.0.

Dropping this etherpad here for lack of another place to put it: https://etherpad.mozilla.org/uaxtsKwv8w. It contains an audit of which code is using which traits, and some notes on use cases.

Nominating.
@brson
Copy link
Contributor Author

brson commented Feb 26, 2014

We need somebody to lay out the design of the 2 or 3 good options.

@pnkfelix
Copy link
Member

Closing as dupe of #12517.

@pnkfelix pnkfelix mentioned this issue Mar 13, 2014
Closed
11 tasks
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 4, 2024
@bors
Auto merge of rust-lang#12579 - J-ZhengLi:issue12569, r=Alexendoo
88d842e 
fix [`manual_unwrap_or_default`] suggestion ignoring side-effects

fixes: rust-lang#12569
closes: rust-lang#12580

change applicability to `MaybeIncorrect` base on suggestion in [this zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/.60manual_unwrap_or_default.60.20suggestion.20removes.20comments)

---

changelog: fix [`manual_unwrap_or_default`] suggestion ignoring side-effects, and adjust its applicability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @pnkfelix