configure relies on 'which' to determine what's installed but 'which' isn't always installed #13147
Labels
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Comments
kchmck
added a commit
to CREATEspace/VowelCat
that referenced
this issue
May 14, 2014
Brought to my attention by rust-lang/rust#13147
notriddle
pushed a commit
to notriddle/rust
that referenced
this issue
Sep 20, 2022
…eykril fix: handle trait methods as inherent methods for trait-related types Fixes rust-lang#10677 When resolving methods for trait object types and placeholder types that are bounded by traits, we need to count the methods of the trait and its super traits as inherent methods. This matters because these trait methods have higher priority than the other traits' methods. Relevant code in rustc: [`assemble_inherent_candidates_from_object()`](https://github.com/rust-lang/rust/blob/0631ea5d73f4a3199c776687b12c20c50a91f0d2/compiler/rustc_typeck/src/check/method/probe.rs#L783-L792) for trait object types, [`assemble_inherent_candidates_from_param()`](https://github.com/rust-lang/rust/blob/0631ea5d73f4a3199c776687b12c20c50a91f0d2/compiler/rustc_typeck/src/check/method/probe.rs#L838-L847) for placeholder types. Notice the second arg of `push_candidate()` is `is_inherent`.
notriddle
pushed a commit
to notriddle/rust
that referenced
this issue
Sep 20, 2022
notriddle
pushed a commit
to notriddle/rust
that referenced
this issue
Sep 20, 2022
…erent-methods, r=lnicola fix: Fix a crash introduced in rust-lang#13147 Reverts rust-lang/rust-analyzer#13147 https://github.com/rust-lang/rust-analyzer/actions/runs/3041499441/jobs/4898678721#step:18:62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The configure script first validates that all the commands it needs exist. It does this with the
whichcommand, which itself doesn't always exist (tested on a stock EC2 fedora 20 image). Per @thestinger,shhas thecommand -vbuiltin that is equivalent for this purpose.The text was updated successfully, but these errors were encountered: