Use new attribute syntax everywhere #13478

Closed
Manishearth opened this Issue Apr 12, 2014 · 5 comments

Projects

None yet

3 participants

@Manishearth
The Rust Programming Language member

#2569 changes inner attribute syntax. While solving #13476 I realized that there were a lot more occurrences of the old syntax throughout the repo. I guess these should be fixed.

@Manishearth Manishearth added a commit to Manishearth/rust that referenced this issue Apr 12, 2014
@Manishearth Manishearth Use new inner attribute syntax everywhere (#13478) a30a0cd
@Manishearth
The Rust Programming Language member

The above commits were generated with sed, so I'm not entirely sure if they are valid.

@Manishearth
The Rust Programming Language member

Not yet PRing since this is based on #13477

@huonw
The Rust Programming Language member

Feel free to submit a PR with the commits from #13477 included, iirc Github will automatically drop them from the diff if that PR lands first (and if the new PR lands first then... both sets of features have landed).

@Manishearth
The Rust Programming Language member

Alright. It still says that the branches can't be automerged, but that shouldn't be a big issue i guess. Filed #13493

@steveklabnik

With #13493 merged, I'm closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment