-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Open
Labels
C-bugCategory: This is a bug.Category: This is a bug.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
The comment says that only stage 0 or stage 2 rustdoc is used, but the user can simply request stage 1 rustdoc.
rust/src/bootstrap/src/core/build_steps/tool.rs
Lines 667 to 672 in 8de4c72
#[derive(Debug, Clone, Hash, PartialEq, Eq, Ord, PartialOrd)] | |
pub struct Rustdoc { | |
/// This should only ever be 0 or 2. | |
/// We sometimes want to reference the "bootstrap" rustdoc, which is why this option is here. | |
pub compiler: Compiler, | |
} |
tested by putting assert_ne!(self.compiler.stage, 1)
in Rustdoc::run
, then running ./x doc --stage 1 library/core
, which causes the added assertion to fail.
fmease
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bug.Category: This is a bug.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)