CharOffsets should impl `Iterator<(char, uint)>` instead of `Iterator<(uint, char)>`

[liigo]

to match with its name, Char+Offset.

(Another option is rename CharOffsets to OffsetChars, and rename StrSlice::char_indices to index_chars.)

[huonw]

The current layout matches with .enumerate() (which makes sense, IMO, since it's effectively just a fancier .enumerate). Furthermore, Rust being strongly typed means that it's very very hard to get things wrong, even if the names aren't perfectly descriptive.

That's not to say that we can't improve the names, though.

[lifthrasiir]

IndexedChars?

[pczarn]

EnumeratedChars?

[bluss]

indexed_chars & IndexedChars sound good, but it's a shame to break every parser out there just for a renaming.. (Note: they are byte indices, not ordinals.)

[steveklabnik]

CharOffsets no longer exists, was it renamed, or just removed?

[huonw]

Renamed to CharIndices.

[steveklabnik]

Ah. This has been marked as stable. @aturon ?

[aturon]

I agree with @huonw that matching enumerate is desirable here.

I also agree that indexed_chars would be a reasonable substitute, but not sure if it's worth changing (and still feels slightly more awkward than the current name).

In any case, nominating for 1.0-beta P-backcompat-libs.

[pnkfelix]

closing, wont fix