core::unsafe::reinterpret_cast should move in its argument?

[brson]

When used with pointer types this function is almost always paired with unsafe::leak to make the caller forget about one of the pointers. This would not be necessary if reinterpret_cast consumed the input value.

[marijnh]

Use + (copy) mode instead. It'll do what you want (move when possible, copy otherwise), without inconveniencing all callers.

[brson]

I think I disagree that it will do what I want in this case. In most cases copy mode is better, but when I am casting pointers around I never want to accidentally copy a vector and receive a pointer to a different vector.

[marijnh]

That's a good point. But you sometimes do want to keep on using the original vector in some way. I guess you could cast it back again.

[marijnh]

Oh an also, vectors aren't the only thing we're casting. I think this is perfectly sane code that should probably work:

let x = @box;
let ptr = unsafe::reinterpret_cast(x);
do_something_with(x);

[brson]

Yes, you are right. Maybe it calls for two different functions.

[brson]

I've added unsafe::transmute that does reinterpret_cast + leak. Considering this closed.