Skip to content

Consider changing the Rust ABI back to fastcall #1835

@brson

Description

@brson

We originally switched to CDECL because of concerns that the stack growth check was going to require more registers than were available under the fastcall convention. It turns out that LLVM optimizes unexported functions to fastcall (and disabling that behavior is not straightforward) so we had to support stack growth with fastcall anyway. The only time we actually have to spill the stack growth check onto the stack is on i386 OS X where the fastcall frame size is greater than 256 bytes. Not using fastcall because of that is potentially a big price to pay.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-codegenArea: Code generationI-slowIssue: Problems and improvements with respect to performance of generated code.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions