Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustbook has some errors when validating HTML #26013

Closed
azerupi opened this issue Jun 4, 2015 · 0 comments · Fixed by #26017
Closed

Rustbook has some errors when validating HTML #26013

azerupi opened this issue Jun 4, 2015 · 0 comments · Fixed by #26017
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@azerupi
Copy link
Contributor

azerupi commented Jun 4, 2015

I've tested html validation of the rust book with the W3C validator and there is only one error, but it is all over the place. There is one id that appears multiple times #rust-example-rendered. If it appears that often it should be a class not an id.

I have tested multiple pages randomly and it seems like the only error :)
So good job !

Link to validator
@alexcrichton alexcrichton added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 4, 2015
Stebalien added a commit to Stebalien/rust that referenced this issue Jun 4, 2015
@Stebalien
Fix order of rustdoc arguments.
4c5029a 
rust-example-rendered should be a class, not an id.

fixes rust-lang#26013
@Stebalien Stebalien mentioned this issue Jun 4, 2015
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this issue Jun 5, 2015
@steveklabnik
Rollup merge of rust-lang#26017 - Stebalien:fix-rustdoc, r=alexcrichton
e0f6ed8 
rust-example-rendered should be a class, not an id.

fixes rust-lang#26013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix order of rustdoc highlight arguments. Stebalien/rust
2 participants
@alexcrichton @azerupi