extern crate privacy is "public" without requiring "pub".

[eddyb]

mod foo {
    extern crate std;
}

fn main() {
    println!("{}", foo::std::mem::size_of::<i32>());
}

Try on playpen.

This is due to is_public being true for all ItemExternCrate regardless of whether they are pub.

Even then, pub extern crate is not handled correctly in all cases, see #26775.

[nikomatsakis]

triage: P-high

[nrc]

I'm going to close this and discuss further on #26775 - the two issues are very connected and that issue has more discussion.

This is due to is_public being true for all ItemExternCrate regardless of whether they are pub.

This is not the case - is_public there is referring to the module itself, not the importing directive, so being true all the time is correct. More on #26775.