Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0252 needs to be updated to new format #35306

Closed
sophiajt opened this issue Aug 4, 2016 · 1 comment
Closed

E0252 needs to be updated to new format #35306

sophiajt opened this issue Aug 4, 2016 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

From: src/test/compile-fail/double-import.rs

Error E0252 needs an updated unit test and span_labels, updating it from:

error[E0252]: a value named `foo` has already been imported in this module
  --> src/test/compile-fail/double-import.rs:25:5
   |
24 | use sub1::foo; //~ NOTE previous import of `foo` here
   |     --------- previous import of `foo` here
25 | use sub2::foo; //~ ERROR a value named `foo` has already been imported in this module [E0252]
   |     ^^^^^^^^^

error: requires `sized` lang_item

error: requires `sized` lang_item

error: requires `sized` lang_item

To:

error[E0252]: a value named `foo` has already been imported in this module
  --> src/test/compile-fail/double-import.rs:25:5
   |
24 | use sub1::foo; //~ NOTE previous import of `foo` here
   |     --------- previous import of `foo` here
25 | use sub2::foo; //~ ERROR a value named `foo` has already been imported in this module [E0252]
   |     ^^^^^^^^^ already imported

To remove the extra "error: requires sized lang_item", remove the:

#![feature(no_core)]
#![no_core]

Lines in the unit test.

@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 4, 2016
@medzin
Copy link
Contributor

medzin commented Aug 5, 2016

I will do it.

bors added a commit that referenced this issue Aug 5, 2016
Updated error message E0252

Fixes #35306 as part of #35233.

r? @GuillaumeGomez
bors added a commit that referenced this issue Aug 6, 2016
Updated error message E0252

Fixes #35306 as part of #35233.

r? @GuillaumeGomez
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 6, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
bors added a commit that referenced this issue Aug 7, 2016
Updated error message E0252

Fixes #35306 as part of #35233.

r? @GuillaumeGomez
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants